[Refactor] Fix incorrect Promise.all usage in app preDeployValidation#7540
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
craigmichaelmartin
left a comment
craigmichaelmartin
left a comment
There was a problem hiding this comment.
The regression test proves a rejection is caught for one extension, but the original bug specifically affected Promise.all with multiple promises.
gonzaloriestra
force-pushed
the
refactor-fix-promise-all-predeploy-11540683829797935190
branch
from
8fbf324 to
0cc2923
Compare
Corrected the Promise.all([this.allExtensions.map(...)]) anti-pattern to properly await extension validations. Added a regression test to ensure that rejections in extension validation are correctly caught by the app's preDeployValidation method.
gonzaloriestra
force-pushed
the
refactor-fix-promise-all-predeploy-11540683829797935190
branch
from
0cc2923 to
ef53a59
Compare
gonzaloriestra
deleted the
refactor-fix-promise-all-predeploy-11540683829797935190
branch
2 participants
WHY are these changes introduced?
Fixes an anti-pattern where
Promise.allwas called with an array containing another array (the result ofmap). This caused the inner promises to be ignored and thepreDeployValidationto resolve immediately without waiting for actual extension validations to complete.WHAT is this pull request doing?
Promise.all([array.map(...)])toPromise.all(array.map(...))inpackages/app/src/cli/models/app/app.ts.packages/app/src/cli/models/app/app.test.tsto ensure extension validations are properly awaited and rejections are caught.How to test your changes?
CI
Checklist
patch) and added a changeset withpnpm changeset add(Note: Changeset skipped to avoid modifying files outside of the immediate fix scope per agent constraints).PR created automatically by Jules for task 11540683829797935190 started by @gonzaloriestra